Auto-activate php easy wins for apm-lang-platform - #7460
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
PRApprover will approve and merge this PR, FAQ, #dx-source-code-management 🛠️ PRApproval Status
➡️ Current phase: approved - manual merge required (this rule does not auto-merge) |
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c0d59765c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - declaration: 'missing_feature (CSS v1.2.0: dd-trace-php ships CSS since v1.19.0, but the sidecar stats exporter retains buckets younger than ~20s (buffer_len=2 * bucket_size=10s) and dd_trace_synchronous_flush passes force=false, so short-lived parametric tests never observe a /v0.6/stats request)' | ||
| component_version: '>=1.19.0' |
There was a problem hiding this comment.
For PHP versions >=1.19.0, this added condition is byte-for-byte identical to the immediately preceding missing_feature condition, so the manifest still reports the test as skipped rather than activating the easy-win case. The same duplicate block was added for the other trace-stats methods below, which makes the PR a no-op for those tests and can keep accumulating redundant skips on future automated runs; please replace these new entries with the intended activation/removal of the skip condition.
Useful? React with 👍 / 👎.
![dd-prapprover-prod-77c48c[bot]](https://avatars.githubusercontent.com/u/244837012?s=60&v=4){kind=small}
5c0d597 to
6a408f3
Compare
new commit added, dismiss all previous approvals
6a408f3 to
fdedc48
Compare
new commit added, dismiss all previous approvals
fdedc48 to
f57ee6e
Compare
new commit added, dismiss all previous approvals
f57ee6e to
26c2e8b
Compare
new commit added, dismiss all previous approvals
26c2e8b to
ed01859
Compare
new commit added, dismiss all previous approvals
ed01859 to
932322f
Compare
new commit added, dismiss all previous approvals
932322f to
c2ad359
Compare
new commit added, dismiss all previous approvals
c2ad359 to
90fe071
Compare
new commit added, dismiss all previous approvals
🎉 All green!🧪 All tests passed 🔗 Commit SHA: 9499d82 | Docs | View more details | Give us feedback! |
5f8340b to
aa57394
Compare
aa57394 to
6258741
Compare
new commit added, dismiss all previous approvals
6258741 to
7985954
Compare
new commit added, dismiss all previous approvals
7985954 to
d0ab566
Compare
d0ab566 to
1fbff5f
Compare
new commit added, dismiss all previous approvals
1fbff5f to
7c1ce83
Compare
new commit added, dismiss all previous approvals
7c1ce83 to
2bfd26e
Compare
new commit added, dismiss all previous approvals
2bfd26e to
288749a
Compare
new commit added, dismiss all previous approvals
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
288749a to
9499d82
Compare
new commit added, dismiss all previous approvals
Automated activation of easy-win tests for
phpowned byapm-lang-platformView nightly workflow run