CWS: thread context sharing scenario should work with appsec enabled - #7577
CWS: thread context sharing scenario should work with appsec enabled#7577danielmercier wants to merge 1 commit into
Conversation
|
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c82e4b9313
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| doc=doc, | ||
| weblog_categories=[WeblogCategory.dd_trace], | ||
| appsec_enabled=False, # unrelated to this feature, keep the CWS signal clean | ||
| appsec_enabled=True, |
There was a problem hiding this comment.
This does not actually test the stated AppSec-only configuration: EndToEndScenario defaults iast_enabled to True, which causes WeblogContainer to inject DD_IAST_ENABLED=true and several related IAST variables. When this test is enabled, a tracer whose context-sharing behavior is activated or altered by IAST could pass even if enabling AppSec alone does not work, producing a misleading result. Pass iast_enabled=False alongside appsec_enabled=True to isolate the condition this scenario is intended to validate.
Useful? React with 👍 / 👎.
c82e4b9 to
5ed7258
Compare
2 participants
Motivation
This tests the CWS correlation end to end. This should work when only appsec is enabled.
Changes
Run the thread context sharing scenario without any custom env var, just appsec enabled.