Skip to content

[NO TICKET ] Mv guard & logger up before list() to prevent crashes in transfers/profiling.py #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chasetmartin merged 1 commit into from
Jan 23, 2026
Merged

[NO TICKET ] Mv guard & logger up before list() to prevent crashes in transfers/profiling.py #422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions transfers/profiling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from dataclasses import dataclass
from datetime import datetime
from pathlib import Path
from typing import Callable, Iterable, Any
from typing import Callable, Iterable, Any, Optional

from services.gcs_helper import get_storage_bucket
from transfers.logger import logger
Expand Down Expand Up @@ -84,13 +84,14 @@ def run(
return result, artifact


def upload_profile_artifacts(artifacts: Iterable[ProfileArtifact]) -> None:
def upload_profile_artifacts(artifacts: Optional[Iterable[ProfileArtifact]]) -> None:
"""Upload generated profiling artifacts to the configured storage bucket."""

artifacts = list(artifacts)
if not artifacts:
logger.info("No profiling artifacts to upload")
return

artifacts = list(artifacts)

bucket = get_storage_bucket()
for artifact in artifacts:
for path in (artifact.stats_path, artifact.report_path):
Expand Down
Loading