Skip to content

BDMS-722: Refactor WellShow UI to Card components, consolidate physical properties, and add historic depth to water support#267

Merged
TylerAdamMartinez merged 3 commits intostagingfrom
TAM-BDMS-722
Apr 28, 2026
Merged

BDMS-722: Refactor WellShow UI to Card components, consolidate physical properties, and add historic depth to water support#267
TylerAdamMartinez merged 3 commits intostagingfrom
TAM-BDMS-722

Conversation

@TylerAdamMartinez
Copy link
Copy Markdown
Contributor

Why

This PR addresses the following problem/context:

  • UI component names were incorrect, using Accordion instead of Cards
  • Missing support for the historic_depth_to_water field in the UI

How

Implementation summary - the following was changed/added/removed:

  • Renamed multiple components from *Accordion → *Card for consistency
  • Removed WellPhysicalPropertiesAccordion and merged its logic into ConstructionInfoCard.
  • Added support for historic_depth_to_water field in IWell interface and UI display

Notes

Any special considerations, workarounds, or follow-up work to note?

  • @jeremyzilar, the InlineRow uses a length-based (value.length > 30) for layout — may need refinement later

@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-tam-bdms-722-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

Copy link
Copy Markdown
Contributor

@jeremyzilar jeremyzilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the Accordion --> Card changes

@jeremyzilar
Copy link
Copy Markdown
Contributor

Mind fixing the Vite Test in this?

Error: Error: [vitest] No "EquipmentCard" export is defined on the "@/components" mock. Did you forget to return it from "vi.mock"?

@github-actions
Copy link
Copy Markdown

Preview Deployment

Preview URL: https://preview-tam-bdms-722-auejgdbofq-uc.a.run.app

Note: This preview uses the staging API endpoints.

Copy link
Copy Markdown
Contributor

@jeremyzilar jeremyzilar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐻‍❄️

@TylerAdamMartinez TylerAdamMartinez merged commit d165278 into staging Apr 28, 2026
3 of 4 checks passed
@TylerAdamMartinez TylerAdamMartinez deleted the TAM-BDMS-722 branch April 28, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants