ellipsis handle hyperlinks#459
Open
appukuttan-shailesh wants to merge 1 commit intoDataTables:masterfrom
Open
Conversation
Collaborator
|
Thank you! I think I'd probably prefer to use regex for this rather than writing it into the DOM and reading it back. That is technically more correct, but it's also slower. I'll look into this for the next release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that there were issues (in my case no content visible within cell) when using the ellipsis renderer for cells with long text and also having hyperlinks: e.g.
<td><a href="www.google.com">Link to GOOGLE</a></td>I figured out that this was because the ellipsis was being applied to
<a href="www.google.com">Link to GOOGLE</a>and notLink to GOOGLE, as is required. I therefore updated the script to handle the same, i.e. to extract the outer tag, have the shortening on its contents, and then reapply the previously extracted outer tag. The implementation provided here works for me.(I am a noob with JS, so the implementation might not be great.)