ScrollResize - Fix max-height as the size of the table#603
Open
rodriformiga wants to merge 1 commit intoDataTables:masterfrom
Open
ScrollResize - Fix max-height as the size of the table#603rodriformiga wants to merge 1 commit intoDataTables:masterfrom
rodriformiga wants to merge 1 commit intoDataTables:masterfrom
Conversation
If the table height is smaller than the avaliable height, the size will be the table size. For example if I filter zero records on serch field.
Contributor
|
Hi - thanks for the PR. Does this still work if you filter down and then delete the filter? Or does it leave the viewport in its reduced state? I think there are cases where the current behaviour is desirable (e.g. this one), but I can see that it might not be what is always wanted. |
Author
Contributor
|
Yeah, its a good point. There was a plugin a while back that would fill in fake rows to take up the space and make it a bit less empty. I think I'll leave this one open if that is okay, and see if it can garner any feedback from others who might be using or looking for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

If the table height is smaller than the avaliable height, the size will be the table size. For example if I filter zero records on serch field.
Are you happy for it to be included and distributed under the MIT license? ✔️/❌