-
-
Notifications
You must be signed in to change notification settings - Fork 258
WIP: Update tests and build #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We currently have From packages/analytics-utils/src/index.js We need to fix these so we only import what we use. Can you update the package.json of the analytics-utils to expose the exports and also update the library to export treeshakeable exports @claude |
|
💬 Claude Code execution complete 📊 Execution Info: Pull Request #498 | Unknown (401 files) | @DavidWells 💡 Example commands for Claude: 🔍 Analysis & Review:
🛠️ Tasks & Implementation:
📚 Management & Operations:
🔀 PR Specific:
🔄 Rerun: You can run again anytime with |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
@claude try again with #498 (comment) |
|
Claude finished @DavidWells's task —— View job ✅ Completed: analytics-utils treeshakeable exportsI've successfully converted the analytics-utils package to use treeshakeable named exports instead of the default import + destructuring pattern. Todo List:
Changes Made:
Results:
The analytics-utils package now supports optimal tree-shaking! 🌳✂️ |
- Add proper exports field to analytics-utils package.json for modern ESM resolution - Convert default import + destructuring to named imports in analytics-core - This enables better tree-shaking as consumers can import only the functions they need Co-authored-by: David Wells <[email protected]>
|
Ok great. Now make sure all the new uvu tests run and work. We want the uvu tests to match files that end in .test.js just like the analytics core package Thanks @claude |
|
Claude finished @DavidWells's task —— View job ✅ uvu tests now consistently match .test.js filesTodo List:
✅ Completed: Updated 11 packages to ensure uvu tests consistently match Changes Made: All packages now use the same file pattern as Updated packages:
Results:
Note: To verify tests actually run, you would need to install dependencies ( |
- Add file pattern '.test.([mc]js|[jt]sx?)$' to all uvu test scripts - Ensures all packages consistently find .test.js files like analytics-core - Updated 10 packages that were missing file patterns: - @analytics/aws-pinpoint - @analytics/fullstory - @analytics/control-flow-utils - @analytics/listener-utils - @analytics/queue-utils - @analytics/storage-utils - @analytics/type-utils - @analytics/url-utils - analytics-utils - @analytics/visitor-source - Added test script to main analytics package Co-authored-by: David Wells <[email protected]>
Update ESM imports in core and convert tests to uvu