chore(docs): sweep aftermath - hasContent null contract, bisect note, debug-overlay guides#166
Merged
Merged
Conversation
… debug-overlay guides Documents and pins the SectionLookup.hasContent null tolerance that five v2 presets rely on since the import sweep folded their explicit guards (SectionLookupTest guards the contract against a future exhaustive-switch rewrite). Adds a CHANGELOG Internal note recording the sweep's mechanical code rewrites (~40 files: Template record conversions, Collections.addAll, wildcard imports, guard folding) so future bisects do not skip f04a7dc on the strength of its message. Extends getting-started and production-rendering with the DocumentDebugOptions node-label workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Findings 9–10 of the post-merge review, plus the deferred docs follow-up:
SectionLookup.hasContentnull contract documented and pinned. The import sweep folded five presets' explicitsection == nullguards intohasContent's undocumented null tolerance; the Javadoc now statesnull → falseis a contract (call sites feed straight fromfirstMatching(...)), andSectionLookupTestpins it against a future exhaustive-switch rewrite of the sealedCvSectionhierarchy.f04a7dcesweep also carried mechanical code rewrites (~40 files: privateTemplate→ records,Collections.addAll, wildcard imports, guard folding) beyond its "imports/Javadoc only" message — verified behavior-preserving at merge time, recorded so a future bisect doesn't skip the commit.getting-started.mdandoperations/production-rendering.mdgain theDocumentDebugOptionsnode-label workflow next to their existingguideLinessections.Verification
Full gate:
./mvnw verify -pl .— 1241 tests, 0 failures, BUILD SUCCESS (post-#165 develop merged in).