refactor(style): move ShapeOutline ring math into ShapeRings (file under 500 LOC)#182
Open
DemchaAV wants to merge 2 commits into
Open
refactor(style): move ShapeOutline ring math into ShapeRings (file under 500 LOC)#182DemchaAV wants to merge 2 commits into
DemchaAV wants to merge 2 commits into
Conversation
…der 500 LOC) - star / regularPolygon / directional vertex generation + the toPoints/clamp helpers move to the existing package-private ShapeRings; the public ShapeOutline factories become thin wrappers - behaviour-preserving: the 22 ShapeOutlineTest vertex pins stay green - ShapeOutline 560 -> 490 LOC; ShapeRings gains 4 direct unit tests (star, regularPolygon, directional, toPoints) Follow-up to the Path-clipper PR which pushed the file over the 500 line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hygiene follow-up to the Path-clipper PR (#181), which pushed
ShapeOutline.javaover the 500-LOC line. Discharges the senior-review flag.star/regularPolygon/directionalvertex generation and thetoPoints/clampUnithelpers move to the existing package-privateShapeRings; the publicShapeOutlinefactories become thin wrappers.ShapeOutlineTeststay green untouched.ShapeOutline560 → 490 LOC;ShapeRingsgains 4 direct unit tests (star facing-up + outer>inner radius, regular polygon inscribed, directional mirror/transpose/null-default, toPoints clamp).Pure internal refactor — no public API change, no CHANGELOG entry. Stacked on #181 (it touches the same file); merge after it.
./mvnw verify -pl .→ BUILD SUCCESS.