fix(pipeline): persist call-site line on CALLS edges#508
Open
alexisperinger-ux wants to merge 2 commits into
Open
fix(pipeline): persist call-site line on CALLS edges#508alexisperinger-ux wants to merge 2 commits into
alexisperinger-ux wants to merge 2 commits into
Conversation
Persist CBMCall.start_line as a "line" property on CALLS edges in both resolution paths (finalize_and_emit + calls_emit_edge), so call-site lines are queryable instead of needing grep. Scoped to CALLS only: route/config edge props feed full-only predump passes the incremental path does not re-run, so changing them desyncs full vs incremental indexing. Verified: full suite matches unpatched main; line present on CALLS both paths. Fixes DeusData#503 Signed-off-by: alexisperinger-ux <alexis.peringer@iss-stoxx.com>
Indexes a Go fixture where Helper() is called on line 8 and asserts the Main->Helper CALLS edge persists a line property (line:8) in its JSON props. Refs DeusData#503. Signed-off-by: alexisperinger-ux <alexis.peringer@iss-stoxx.com>
alexisperinger-ux
force-pushed
the
fix/persist-call-site-line
branch
from
d6affbd to
fae040d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CALLSedges did not carry the source line of the call site, even thoughCBMCall.start_lineis already captured during extraction. This persists it as alineproperty onCALLSedges in both resolution paths (finalize_and_emitfor parallel/registry, a newcalls_emit_edgehelper for serial/LSP), so call-site lines are queryable (MATCH ()-[r:CALLS]->() RETURN r.line) instead of needing grep.Fixes #503.
Scope: CALLS only
lineis attached toCALLSedges only. Route/config edge props (HTTP_CALLS/ASYNC_CALLS/CONFIGURES) feed the full-only predump passes (create_route_nodes/create_data_flows), which the incremental path does not re-run. Altering those props desyncs full vs incremental indexing (tests/test_incremental.cincr_accuracy_vs_full). Restricting toCALLSkeeps those props byte-identical to baseline and preserves full/incremental parity.Testing
scripts/test.sh): same failure profile as unpatchedmain(only the pre-existing RSS-ceiling test differs); the previously failingincr_accuracy_vs_fullnow passes.CALLSedges carry accurate line numbers on both resolution paths; non-CALLSedge props are unchanged.Changes
src/pipeline/pass_parallel.c:finalize_and_emitappends,"line":NforCALLS.src/pipeline/pass_calls.c:calls_emit_edgehelper splices,"line":NforCALLSand routes the call-edge sites through it.