Skip to content

Isolate smoke-test dry-run state#783

Merged
DeusData merged 1 commit into
DeusData:mainfrom
SS-42:test/smoke-dry-run-isolation
Jul 3, 2026
Merged

Isolate smoke-test dry-run state#783
DeusData merged 1 commit into
DeusData:mainfrom
SS-42:test/smoke-dry-run-isolation

Conversation

@SS-42

@SS-42 SS-42 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

This isolates smoke-test dry-run subcommands from the developer's real home directory and cache.

Phase 6 now runs install --dry-run, uninstall --dry-run, update --dry-run, and the config set/get/reset round trip under a temporary HOME, XDG_CONFIG_HOME, APPDATA, LOCALAPPDATA, CBM_CACHE_DIR, and private PATH. The temporary tree is removed by the existing cleanup trap.

Observed environment: macOS 26.5.2 (25F84), Darwin 25.5.0 arm64, Apple clang 21.0.0. The isolation is shell/environment based and should apply across supported platforms.

Test plan

  • make -f Makefile.cbm build/c/codebase-memory-mcp CC=clang CXX=clang++
  • scripts/smoke-test.sh build/c/codebase-memory-mcp

@SS-42 SS-42 requested a review from DeusData as a code owner July 2, 2026 18:42
@SS-42 SS-42 force-pushed the test/smoke-dry-run-isolation branch 2 times, most recently from 1a541d7 to 8cb7ed7 Compare July 2, 2026 18:43
Signed-off-by: SS-42 <noreply@incogni.to>
@SS-42 SS-42 force-pushed the test/smoke-dry-run-isolation branch from 8cb7ed7 to 9e57c6c Compare July 2, 2026 20:01
@DeusData DeusData added bug Something isn't working ux/behavior Display bugs, docs, adoption UX priority/normal Standard review queue; useful PR with ordinary maintainer urgency. labels Jul 3, 2026
@DeusData

DeusData commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Thanks for tightening the smoke-test dry-run isolation. Triage: UX/test-infra safety change touching scripts.

Because this changes script behavior around HOME, XDG, APPDATA, PATH, and cache directories, review will check that dry-run commands cannot mutate a developer real config and that cleanup is reliable on failure. Please keep the test evidence in the PR description current after any updates.

@DeusData

DeusData commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Thanks — this fixes a real hygiene bug (the smoke battery was mutating the developer's actual config via 'config set'). Env-only isolation into a script-owned mktemp home, byte-identical assertions, clean teardown. One non-blocking question we'll keep an eye on: whether Windows resolves the profile via USERPROFILE/known-folder APIs in any of these paths — worst case isolation is incomplete there, never worse than today. Merging.

@DeusData DeusData merged commit cde1675 into DeusData:main Jul 3, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working priority/normal Standard review queue; useful PR with ordinary maintainer urgency. ux/behavior Display bugs, docs, adoption UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants