fix(smoke): serve the -portable linux asset from the artifact server#894
Merged
Conversation
The dry-run smoke Phase 14 runs the binary's real `update` command, which on linux downloads the fully-static "-portable" asset (build_update_url in src/cli/cli.c appends -portable on linux; _build.yml's build-linux-portable job ships codebase-memory-mcp[-ui]-linux-<arch>-portable.tar.gz). The smoke artifact server only served the non-portable name, so `update` 404'd and the config- refresh assertion failed on every linux smoke leg. The mismatch (the smoke half of the -portable delivery change) was masked until every smoke leg became a required gate. Mirror the tarball under the -portable name on linux (standard and ui) so the served names match build_update_url; checksums.txt globs *.tar.gz and picks up the new files. Verified the fixed logic serves the exact name the binary requests for both variants; the gating smoke Phase 14 is the regression guard. Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dry-run smoke Phase 14 runs the binary's real
updatecommand, which onlinux downloads the fully-static "-portable" asset (build_update_url in
src/cli/cli.c appends -portable on linux; _build.yml's build-linux-portable job
ships codebase-memory-mcp[-ui]-linux--portable.tar.gz). The smoke artifact
server only served the non-portable name, so
update404'd and the config-refresh assertion failed on every linux smoke leg. The mismatch (the smoke half
of the -portable delivery change) was masked until every smoke leg became a
required gate.
Mirror the tarball under the -portable name on linux (standard and ui) so the
served names match build_update_url; checksums.txt globs *.tar.gz and picks up
the new files. Verified the fixed logic serves the exact name the binary
requests for both variants; the gating smoke Phase 14 is the regression guard.
Root cause
The release dry run's smoke Phase 14 runs the binary's real
update, which on linux requests the static-portableasset (build_update_url). The smoke artifact server (_smoke.yml) only served the non--portablename →update404'd → config-refresh assertion failed on every linux smoke leg (ui + standard). Masked until #882 made each smoke leg a required gate; surfaced in dry run 28748103992.Fix
Serve the
-portabletarball name on linux (both variants). Real releases already ship it (_build.ymlbuild-linux-portable); only the fake smoke server was missing it. Verified locally that the served names now match what the binary requests.