Skip to content

fix(ci): clang-format drift and license-gate false positive from the perf merge#922

Merged
DeusData merged 2 commits into
mainfrom
fix/lint-license-gate
Jul 6, 2026
Merged

fix(ci): clang-format drift and license-gate false positive from the perf merge#922
DeusData merged 2 commits into
mainfrom
fix/lint-license-gate

Conversation

@DeusData

@DeusData DeusData commented Jul 6, 2026

Copy link
Copy Markdown
Owner

Two follow-ups to #921 caught by the dry run:

  • clang-format pass over six files touched by the perf campaign (formatter was not run before merge; cppcheck clean).
  • The rotsq.h header comment mentioned the license identifier of a third-party library's bundled dependency while explaining we deliberately avoid that library; ScanCode matches the bare identifier string and blocks. Reworded to state provenance directly (written from the published papers, nothing vendored or derived). Verified: a normalized shared-line sweep of rotsq.{h,c} against both public reference implementations finds zero overlap beyond include-statement boilerplate.

Whitespace + comment changes only; local make lint-ci green.

DeusData added 2 commits July 6, 2026 23:42
…fer files

Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
The header referenced the license identifier of a third-party library's
bundled dependency while explaining that the implementation deliberately
does not use that library. License scanners match the bare identifier
string and misclassify the file. Reword to state provenance directly:
written from the published papers, nothing vendored or derived.
Comment-only change; also picks up the formatter pass on this file.

Signed-off-by: Martin Vogel <martin.vogel.tech@gmail.com>
@DeusData DeusData merged commit a78da97 into main Jul 6, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant