Skip to content

[DEVOPS] fix(chocolatey): update silent arguments and valid exit codes for installation and uninstallation scripts #4525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Richard Boisvert (rbstp) merged 1 commit into from
Mar 26, 2026
+11 −18
Merged

[DEVOPS] fix(chocolatey): update silent arguments and valid exit codes for installation and uninstallation scripts #4525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package/chocolatey/unigetui/tools/chocolateyInstall.template.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ $PackageArgs = @{
packageName = $PackageName
url = $Url
fileType = 'exe'
silentArgs = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP- /ALLUSERS /NoWinGet /NoAutoStart'
validExitCodes= @(0, 3010)
silentArgs = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP- /NoEdgeWebView /NoVCRedist /NoChocolatey /EnableSystemChocolatey'
validExitCodes= @(0, 3010, 1641)
checksum = '$VAR2$'
checksumType = 'sha256'
}
Expand Down
25 changes: 9 additions & 16 deletions package/chocolatey/unigetui/tools/chocolateyUninstall.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,32 +1,25 @@
$ErrorActionPreference = 'Stop'

$PackageName = 'unigetui'

$PackageArgs = @{
packageName = $PackageName
softwareName = 'UniGetUI'
packageName = $env:ChocolateyPackageName
softwareName = 'unigetui*'
fileType = 'exe'
silentArgs = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART'
validExitCodes= @(0, 3010)
silentArgs = '/VERYSILENT /SUPPRESSMSGBOXES /NORESTART /SP-'
validExitCodes= @(0, 3010, 1605, 1614, 1641)
}

[array]$Key = Get-UninstallRegistryKey -SoftwareName $PackageArgs['softwareName']

if ($Key.Count -eq 1) {
$Key | % {
$uninstallExe = $_.UninstallString -replace '"', ''
if (Test-Path $uninstallExe) {
$PackageArgs['file'] = $uninstallExe
Uninstall-ChocolateyPackage @PackageArgs
} else {
Write-Warning "Uninstaller not found at $uninstallExe"
}
$PackageArgs['file'] = "$($_.UninstallString)"
Uninstall-ChocolateyPackage @PackageArgs
}
} elseif ($Key.Count -eq 0) {
Write-Warning "$PackageName has already been uninstalled."
Write-Warning "$($PackageArgs['packageName']) has already been uninstalled by other means."
} elseif ($Key.Count -gt 1) {
Write-Warning "$($Key.Count) matches found!"
Write-Warning "To prevent accidental data loss, no programs will be uninstalled."
Write-Warning "The following keys were matched:"
$Key | % {Write-Warning "- $($_.DisplayName)"}
Write-Warning "Please alert package maintainer the following keys were matched:"
$Key | % { Write-Warning "- $($_.DisplayName)" }
}