feat: add support for farcaster social network integration#12272
Closed
feat: add support for farcaster social network integration#12272
Conversation
swkatmask
force-pushed
the
feat/firefly-token
branch
3 times, most recently
from
cfc05f6 to
8f55dff
Compare
swkatmask
force-pushed
the
feat/firefly-token
branch
from
2dea943 to
358bb73
Compare
Jack-Works
reviewed
Sep 3, 2025
| ) {} | ||
|
|
||
| serialize(): `${SessionType}:${string}` { | ||
| const body = JSON.stringify({ |
Member
There was a problem hiding this comment.
In case this is part of some protocol, or will be signed, you may need json-stable-stringify
Jack-Works
requested changes
Sep 5, 2025
| @@ -0,0 +1,41 @@ | |||
| export class AbortError extends Error { | |||
Member
There was a problem hiding this comment.
looks like this class is never constructed. why not make it simple, isAbortError?
| } | ||
|
|
||
| // failed to patch the signer | ||
| if (error instanceof FarcasterPatchSignerError) throw error |
Member
There was a problem hiding this comment.
this class is never constructed, in which case this will be hit?
Member
|
The failed test is broken from nodejs 24.5.0 (known good) to 24.7.0 (known bad). I will investigate this. |
swkatmask
force-pushed
the
feat/firefly-token
branch
2 times, most recently
from
5840d57 to
5c5001e
Compare
swkatmask
force-pushed
the
feat/firefly-token
branch
from
fa4564b to
12d7322
Compare
Member
|
Hi you should pick #12276 to fix the test failure |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MF-0000 FW-0000