Fix parsing IMAP responses containing 8-bit bytes - #177
Merged
Conversation
stevebauman
marked this pull request as ready for review
August 10, 2026 01:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175
This PR fixes the tokenizer throwing an exception when an IMAP server includes 8-bit bytes in human-readable response text.
The tokenizer previously accepted only printable ASCII characters inside ATOMs. As a result, responses containing raw bytes from mailbox names would stop at the first 8-bit byte and leave the rest of the response unread.
ATOMs now reject only control bytes and DEL while continuing to split on the existing delimiters. This allows the complete response to be consumed while preserving the protection against invalid control bytes added in #172.