feat: transfers approval inbox with pending/requests/history and notifications center - #1366
Conversation
- FE-08: Transfers page with pending requests tab (approve/reject with reason), my requests tab (cancel while pending), and history tab; pending badge count in sidebar; role-gated approval actions - FE-09: Notifications page with paginated list, unread/filtered views, mark-as-read on click, mark-all-read, notification links to resources; Bell icon added to sidebar Closes DistinctCodes#1096 Closes DistinctCodes#1097
|
@BashMan11 is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@BashMan11 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
yusuftomilola
left a comment
There was a problem hiding this comment.
Reviewed. Solid rework of the transfers page — replaces the old inline-styled placeholder with a proper Pending/My Requests/History tabbed inbox, approve/reject-with-reason/cancel actions, and a pending-count badge. New notifications page has sensible unread filtering and mark-all-read. Both are local-state/mock-data only for now (no backend calls), consistent with how my-assets/custom-fields in #1362 handled similar not-yet-wired pages — nothing here claims a persisted action that didn't happen. Worth a fast follow-up to wire these to the real /transfers and a notifications endpoint now that the backend guards are in place from #1363.
Approving.
Resolve duplicate lucide-react import conflict in sidebar.tsx: this branch and DistinctCodes#1358 both added Store/FileText icon imports for the same nav items (already merged), plus this PR's own Bell import for the new notifications link. Deduplicated to a single import list.
Summary
This PR implements the transfers approval inbox and notifications center.
Changes
[FE-08] Transfers Approval Inbox
[FE-09] Notifications Center
/notificationspage with paginated notification listVerification
Closes #1100
Closes #1101
Closes #1102
Closes #1103