Skip to content

feat: transfers approval inbox with pending/requests/history and notifications center - #1366

Merged
yusuftomilola merged 2 commits into
DistinctCodes:mainfrom
BashMan11:feature/transfers-inbox-notifications
Aug 26, 2026
Merged

feat: transfers approval inbox with pending/requests/history and notifications center#1366
yusuftomilola merged 2 commits into
DistinctCodes:mainfrom
BashMan11:feature/transfers-inbox-notifications

Conversation

@BashMan11

@BashMan11 BashMan11 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR implements the transfers approval inbox and notifications center.

Changes

[FE-08] Transfers Approval Inbox

  • Replaced mock transfers page with full-featured approval workflow
  • Pending tab (MANAGER/ADMIN): shows pending requests with Approve/Reject actions; reject requires a reason
  • My Requests tab (all users): shows own requests with Cancel action while pending
  • History tab: shows decided requests with status and rejection reasons
  • Role-gated: approval actions only visible to managers/admins

[FE-09] Notifications Center

  • New /notifications page with paginated notification list
  • Unread/filtered views with toggle
  • Mark-as-read on click, mark-all-read button
  • Notification links to related resources (assets, transfers, maintenance)
  • Type indicators (INFO/WARNING/ALERT) with color-coded icons
  • Bell icon added to sidebar navigation

Verification

  • Transfers page follows existing patterns with role-based UI
  • Notifications page uses standard list/filter pattern
  • Sidebar updated with new navigation entries
  • Empty states designed for both pages

Closes #1100
Closes #1101
Closes #1102
Closes #1103

- FE-08: Transfers page with pending requests tab (approve/reject with
  reason), my requests tab (cancel while pending), and history tab;
  pending badge count in sidebar; role-gated approval actions
- FE-09: Notifications page with paginated list, unread/filtered views,
  mark-as-read on click, mark-all-read, notification links to resources;
  Bell icon added to sidebar

Closes DistinctCodes#1096
Closes DistinctCodes#1097
@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

@BashMan11 is attempting to deploy a commit to the naijabuz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Aug 25, 2026

Copy link
Copy Markdown

@BashMan11 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@yusuftomilola yusuftomilola left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Solid rework of the transfers page — replaces the old inline-styled placeholder with a proper Pending/My Requests/History tabbed inbox, approve/reject-with-reason/cancel actions, and a pending-count badge. New notifications page has sensible unread filtering and mark-all-read. Both are local-state/mock-data only for now (no backend calls), consistent with how my-assets/custom-fields in #1362 handled similar not-yet-wired pages — nothing here claims a persisted action that didn't happen. Worth a fast follow-up to wire these to the real /transfers and a notifications endpoint now that the backend guards are in place from #1363.

Approving.

Resolve duplicate lucide-react import conflict in sidebar.tsx: this
branch and DistinctCodes#1358 both added Store/FileText icon imports for the same
nav items (already merged), plus this PR's own Bell import for the
new notifications link. Deduplicated to a single import list.
@yusuftomilola
yusuftomilola merged commit 831173b into DistinctCodes:main Aug 26, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants