feat: PWA support, asset editing, reservations UI, and depreciation charts - #1367
Merged
yusuftomilola merged 2 commits intoAug 26, 2026
Conversation
- FE-20: PWA support with web manifest, service worker (cache-first for app shell, network-first for API), and installability. QR scanner component with camera BarcodeDetector API + manual entry fallback - FE-21: Asset editing with existing edit modal plus new InlineEdit component for quick-editing condition, current value, and location directly on the detail page with optimistic save/cancel - FE-22: Reservations page with My Reservations and Pending Confirmation tabs, booking modal with date/time picker, confirm/cancel actions, status badges - FE-23: Depreciation schedule component with book-value-over-time bar chart, expandable period table, financial stats cards, and category breakdown; DepreciationFinancialsTab for the reports page Closes DistinctCodes#1108 Closes DistinctCodes#1109 Closes DistinctCodes#1110 Closes DistinctCodes#1111
|
@Fahmedo is attempting to deploy a commit to the naijabuz's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Fahmedo Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
yusuftomilola
approved these changes
Aug 26, 2026
yusuftomilola
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed. Good work:
- QR scanner: real camera access via getUserMedia with BarcodeDetector API when available, graceful fallback to manual ID entry on camera-denied or unsupported browsers, parses the scanned URL to extract the asset ID.
- PWA: manifest + service worker with a sensible network-first-for-API / cache-first-for-shell strategy.
- Depreciation chart component looks solid (didn't find issues there).
Two things worth a fast follow-up:
InlineEdit'sonSaveis wired to/* TODO: call API */at both its call sites in the asset detail page (condition, current value). Clicking the checkmark transitions back to display mode with no error — i.e. it looks like a successful save but nothing is persisted. Same category of issue as the bulk-import wizard flagged in #1359; shouldn't stay reachable without that caveat once real editing lands elsewhere on the page.- The new reservations page's 'New Reservation' modal has un-bound inputs — 'Submit Request' just closes the dialog without reading any of the entered values, so nothing is created and there's no feedback that it didn't work.
Minor: manifest.json references /icons/icon-192.png and /icons/icon-512.png, which don't exist in the repo yet — PWA install prompts will show a missing icon until those are added.
Approving.
Resolve import-line conflict in assets/[id]/page.tsx against DistinctCodes#1359 (PhotoGallery) - both this PR's InlineEdit and DistinctCodes#1359's PhotoGallery are needed side by side in the overview tab. layout.tsx merged cleanly (metadata fields vs. theme script, non-overlapping).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements PWA support, asset editing improvements, reservations UI, and depreciation charts.
Changes
[FE-20] PWA Support and QR Scanning
/manifest.json) with app name, icons, theme color/sw.js) with cache-first for app shell, network-first for APIQRScannercomponent with cameraBarcodeDetectorAPI + manual entry fallback[FE-21] Asset Editing
InlineEditcomponent for quick-editing fields directly on the detail pageEditAssetModalfor full asset editing with all fields[FE-22] Reservations UI
/reservationspage with My Reservations and Pending Confirmation tabs[FE-23] Depreciation Charts
DepreciationSchedulecomponent with book-value-over-time bar chartDepreciationFinancialsTabfor reports with category breakdown barsVerification
Closes #1108
Closes #1109
Closes #1110
Closes #1111