Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
There was a problem hiding this comment.
Additional Suggestions:
- The command structure created in genMessageFactory has the salt in the wrong position, causing decrypted command elements to be misaligned with circuit expectations.
- Command array in operator.ts has salt in wrong position, causing decrypted command elements to misalign with circuit specification
- The WitnessTester type definition for MessageToCommand circuit is missing 'pollId' in the output tuple, while the actual circuit (messageToCommand.circom line 63) declares it as an output signal.
| uint256_from_decimal_string(&data.msgs[i][4]), | ||
| uint256_from_decimal_string(&data.msgs[i][5]), | ||
| uint256_from_decimal_string(&data.msgs[i][6]), | ||
| uint256_from_decimal_string(&data.msgs[i][7]), |
There was a problem hiding this comment.
Test code accesses array indices [0-9] in msgs array, but test JSON data only contained 7 elements per message (indices 0-6), causing index out of bounds error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.