Skip to content

add option to pass options to fastify instance#74

Merged
joshunrau merged 2 commits into
mainfrom
devel
Apr 22, 2026
Merged

add option to pass options to fastify instance#74
joshunrau merged 2 commits into
mainfrom
devel

Conversation

@joshunrau
Copy link
Copy Markdown
Collaborator

@joshunrau joshunrau commented Apr 22, 2026

Summary by CodeRabbit

  • New Features

    • Added support for configurable Fastify adapter options when creating application instances.
  • Chores

    • Updated development dependencies to newer major/minor versions.
    • Removed ESLint suppression directives from utility modules for improved code quality.
    • Enhanced TypeScript configuration with Node.js type definitions.

@joshunrau joshunrau merged commit ba5b897 into main Apr 22, 2026
1 of 2 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 77185b94-8db2-4680-9217-e952d903163a

📥 Commits

Reviewing files that changed from the base of the PR and between 2b15e7f and e1bee78.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • package.json
  • src/app/app.base.ts
  • src/app/app.container.ts
  • src/app/app.factory.ts
  • src/utils/env.utils.ts
  • src/utils/validation.utils.ts
  • tsconfig.json

Walkthrough

Updated devDependencies to major versions (eslint-config, tsconfig, typescript, typedoc), added FastifyAdapterOptions configuration support by threading options through AppFactory → AppContainer → FastifyAdapter, removed unnecessary ESLint suppressions, and added Node.js types to TypeScript compilation.

Changes

Cohort / File(s) Summary
Dependency Updates
package.json, tsconfig.json
Updated devDependencies to newer major versions; added types: ["node"] to compiler options.
Fastify Configuration
src/app/app.base.ts, src/app/app.container.ts, src/app/app.factory.ts
Added new FastifyAdapterOptions type export; extended AppContainerParams and AbstractAppContainer to include optional fastifyOptions field; updated AppFactory.create() and AppContainer.createApplicationInstance() to accept and pass through fastify options.
ESLint Cleanup
src/utils/env.utils.ts, src/utils/validation.utils.ts
Removed unnecessary eslint-disable-next-line comments from return statements.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🚀 Config flows through the layers,
Fastify finds its way,
Options dance from factory to core,
TypeScript types align,
ESLint warnings fade away. ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch devel

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 8.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2207ace) to head (e1bee78).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           60        60           
  Lines          704       704           
  Branches       118       118           
=========================================
  Hits           704       704           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant