Skip to content

Rolling back change that introduce the fix#128

Closed
jdgomez wants to merge 1 commit intoDukecity:mainfrom
jdgomez:main
Closed

Rolling back change that introduce the fix#128
jdgomez wants to merge 1 commit intoDukecity:mainfrom
jdgomez:main

Conversation

@jdgomez
Copy link
Copy Markdown

@jdgomez jdgomez commented Oct 6, 2024

Fixing the issue #126

Mi first github collaboration ever, please notice me any improvements.

As I don't know how the inner repository work as a whole, I limited myself to roll back the breaking change.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2024

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.51%. Comparing base (4ac633e) to head (3c1a8ce).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
Service/CommandSchedulerExecution.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #128   +/-   ##
=========================================
  Coverage     81.51%   81.51%           
  Complexity      290      290           
=========================================
  Files            30       30           
  Lines          1239     1239           
=========================================
  Hits           1010     1010           
  Misses          229      229           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Chris53897
Copy link
Copy Markdown
Collaborator

Tests are green. But my IDE says that
Method 'create' not found in \Doctrine\Persistence\ObjectManager|null

I need to take a closer look.

@jdgomez jdgomez closed this by deleting the head repository Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants