Allocator #3
Open
Allocator #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xmiler
reviewed
Jan 6, 2021
Xmiler
left a comment
Xmiler
left a comment
There was a problem hiding this comment.
Спасибо за возможность посмотреть ваше решение. Замечаний нет.
| @@ -0,0 +1,62 @@ | |||
| #define BOOST_TEST_MODULE Allocator_test_module | |||
There was a problem hiding this comment.
Было бы надежнее покрыть (косвенно) FindAvailableChunk тестом - раз есть реализация
Owner
Author
There was a problem hiding this comment.
Согласен. Но надо другой подход искать, думаю. Надо передать стратегию выбора свободного куска через шаблон или как-нибудь через конструктор. Я еще подумаю над этим =)
Но спасибо за комментарий
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.