Skip to content

Conversation

@jajhall
Copy link
Member

@jajhall jajhall commented Jan 15, 2026

In highsSparseTranspose, now using Astart[numCol] rather than Aindex.size() as number of nonzeros.

In debug, calling HPresolve::checkCSC from HPresolve::toCSC to make sure that CSC index and value are of the correct size, that the entries of index are in bounds, and that there there are no explicit zeros in value arrays. No reason to suspect that anything is wrong, but what might be causing the segfault exposed in #2748?

@jajhall jajhall marked this pull request as draft January 15, 2026 14:31
@jajhall
Copy link
Member Author

jajhall commented Jan 15, 2026

Includes changes relating to #2742, so make this a draft PR until the PR corresponding to #2742 is merged

@jajhall jajhall marked this pull request as ready for review January 23, 2026 17:32
@jajhall jajhall self-assigned this Feb 8, 2026
@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

❌ Patch coverage is 85.27132% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.25%. Comparing base (5e3106b) to head (6375ec8).
⚠️ Report is 6 commits behind head on latest.

Files with missing lines Patch % Lines
highs/lp_data/HighsReformulation.cpp 89.41% 9 Missing ⚠️
highs/presolve/HPresolve.cpp 63.63% 8 Missing ⚠️
highs/util/HighsUtils.cpp 60.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2750   +/-   ##
=======================================
  Coverage   80.24%   80.25%           
=======================================
  Files         348      349    +1     
  Lines       86186    86214   +28     
=======================================
+ Hits        69164    69187   +23     
- Misses      17022    17027    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jajhall jajhall marked this pull request as draft February 8, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant