-
Notifications
You must be signed in to change notification settings - Fork 283
Added checks to identify cause of segfault exposed in #2748 #2750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jajhall
wants to merge
11
commits into
latest
Choose a base branch
from
fix-2748
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… moved (un)doReformulation, handleInfiniteCost and restoreInfiniteCost to it
…size() as number of nonzeros; formatted
Member
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2750 +/- ##
=======================================
Coverage 80.24% 80.25%
=======================================
Files 348 349 +1
Lines 86186 86214 +28
=======================================
+ Hits 69164 69187 +23
- Misses 17022 17027 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
highsSparseTranspose, now usingAstart[numCol]rather thanAindex.size()as number of nonzeros.In debug, calling
HPresolve::checkCSCfromHPresolve::toCSCto make sure that CSC index and value are of the correct size, that the entries of index are in bounds, and that there there are no explicit zeros in value arrays. No reason to suspect that anything is wrong, but what might be causing the segfault exposed in #2748?