Replace edge-currency-monero with react-native-monero-lwsf#5949
Replace edge-currency-monero with react-native-monero-lwsf#5949
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| moneroLightwalletServer: asString | ||
| enableCustomMonerod: asOptional(asBoolean, false), | ||
| moneroLightwalletServer: asString, | ||
| monerodServer: asString |
There was a problem hiding this comment.
Missing asOptional for monerodServer breaks existing settings
High Severity
monerodServer uses asString instead of asOptional(asString, ''), which is inconsistent with enableCustomMonerod on the line above. When upgrading users have existing Monero settings that lack the new monerodServer field, the entire asMoneroUserSettings cleaner will fail. The asMaybe wrapper in MaybeCurrencySetting catches this and falls back to defaultSetting, silently hiding the user's custom LWS server settings. Any subsequent settings change will then overwrite their stored custom values with defaults.
| } | ||
|
|
||
| // console.log('lookhere contextOptions', contextOptions) | ||
| // console.log('lookhere makeMoneroIo', makeMoneroIo != null, makeMoneroIo()) |
There was a problem hiding this comment.
Commented-out debug statements left in code
Low Severity
Commented-out console.log statements with the lookhere debugging prefix and a commented-out old import for edge-currency-monero are left in the code. These are development artifacts that aren't intended for the final commit.
Additional Locations (1)
1 participant
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
noneRequirements
If you have made any visual changes to the GUI. Make sure you have:
Note
High Risk
High risk because it swaps out the Monero native/plugin integration and related build/asset pipeline, which can affect wallet syncing, transaction behavior, and app startup across iOS/Android.
Overview
Monero integration is migrated off the legacy WebPack plugin bundle: removes
webpack/core-jsplugin bundling artifacts, dropsreact-native-mymonero-core, switches toreact-native-monero-lwsf, and wires Monero IO throughedge-currency-accountbased/rn-moneroinEdgeCoreManager(including removing the extra Monero plugin URI/debug path). iOS project resources are updated accordingly (removing the bundlededge-coreasset folder), andedge-core-js/edge-currency-accountbasedare bumped to beta versions.Adds a new
WalletSettingsModalthat combines renaming with per-wallet plugin settings, updates the wallet list menu to use it, and threadswalletSettingValuesthrough the wallet creation/import flows so selected settings are applied at creation time. Introduces awalletSettingsschema inWalletAndCurrencyConstants(initially used for Monero backend selection) and expands Monero custom server UI to separately manage LWS vs full-node (monerod) endpoints, with updated strings/snapshots and some small TypeScriptunknown-catch cleanups.Written by Cursor Bugbot for commit f8faf72. This will update automatically on new commits. Configure here.