Add price impact warning to swap confirmation#5952
Merged
Conversation
e5a4fcc to
88b683a
Compare
j0ntz
commented
Feb 18, 2026
7685652 to
a41f4d6
Compare
swansontec
approved these changes
Feb 21, 2026
Calculate price impact by comparing quote fiat values against market rates. Display the percentage inline next to the fiat price in the TO card, colored by severity (grey <5%, orange 5-15%, red >15%). Show warning cards based on price impact and fee warning state: - Price impact only: dedicated warning card - Both price impact and fee warning: combined card replaces fee warning - Fee warning only: existing behavior preserved
a41f4d6 to
2d188a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG
Does this branch warrant an entry to the CHANGELOG?
Dependencies
None
Description
Context
Asana: "Swap - Price Impact Warning" (P1). When users confirm a swap, the effective rate can differ significantly from the market rate due to liquidity depth, spread, and network fees. Without visibility into this, users may unknowingly accept unfavorable rates.
Changes
biggystringfor precisiondeactivatedText): < 5%warningText): 5–15%dangerText): > 15%SwapConfirmationSceneandExchangeQuoteComponent(render function return types, deprecatedcurrencyCodeusage)CurrencyRow.tsxfrom eslint warning-override listRequirements
If you have made any visual changes to the GUI. Make sure you have: