fix(skills): invoke bundled Python helpers portably - #607
Open
KumamuKuma wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the four audited Python helper invocations in
/understand-domainand/understandso they no longer depend on the caller's current working directory or on one platform-specific Python command.This adds a shared Node launcher that:
python,py -3, andpython3on Windows, andpython3andpythonelsewhere, from the trusted plugin directory;The affected domain extraction, subdomain merge, and full/incremental batch merge commands now resolve both the launcher and helper through
$PLUGIN_ROOT. Regression tests cover command snippets, platform selection, missing/incompatible interpreters, linked installs, paths with spaces, startup failures, and exit/signal propagation.Linked issue(s)
None.
How I tested this
corepack pnpm lintcorepack pnpm --filter @understand-anything/core test— 970 passedcorepack pnpm test— 488 passed, 15 skippedcorepack pnpm exec vitest run --maxWorkers=2— 488 passed, 15 skippeddomain-context.jsonwas generated successfullypython.exein the analyzed project directory; the launcher ignored it and ran Python 3.13 from the trusted resolution pathVersioning
2.9.4to2.9.5in all six authoritative manifests listed inCLAUDE.md