Support a bundled install package#5
Merged
Conversation
When an ignis-*.zip sits next to setup.php, the wizard now installs straight from it: the source selection collapses to an info box, the archive gets extracted in place of the GitHub download and is deleted right after, and a bundled readme.txt is cleaned up together with the self-delete at the end. Without a bundled archive everything behaves exactly as before, so the same setup.php serves both the standalone and the packaged distribution. A missing download method (no curl, no allow_url_fopen) no longer blocks the requirements check when the archive is already there. Also adds a small lint workflow, since this repo had no CI at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Counterpart to EmergencyForge/ignis#296. When an
ignis-*.ziplies next tosetup.php, the wizard installs from it directly: the source-selection step collapses to an info box, the archive is extracted in place of the GitHub download and deleted right after, and a bundledreadme.txtis removed together with the self-delete at the end.Hosts without curl and allow_url_fopen pass the requirements check in this mode, since nothing needs to be downloaded. Without a bundled archive the wizard behaves exactly as before, so the same
setup.phpserves both distributions.Also adds a php-lint workflow - the repo had no CI.