Require PHP 8.3 and fix the bundled-package flow#6
Merged
Conversation
ignis requires PHP 8.3 since the plugin release (composer.json says so), but the setup still let 8.2 through - the install then died at the composer step with a cryptic platform error instead of a clear requirement message up front. The bundled-package mode also ran composer even though the install package ships vendor/ - on typical webspace without exec that killed the whole install. Composer now only runs for git checkouts (main/custom branch). The progress modal reads the hidden mode input too, so a bundled install shows its actual steps instead of 'Verbindung zu GitHub' and 'Repository wird geklont'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two findings from a real install attempt on shared hosting:
vendor/— on webspace withoutexecthat killed the whole install. Composer now only runs for git checkouts (main/custom). The progress modal also reads the hidden mode input, so a bundled install shows its actual steps instead of Verbindung zu GitHub / Repository wird geklont.