Drop empty protocol rail entry when all protocol plugins are off#319
Merged
Conversation
With eNOTF, fireTab and the MANV board all disabled, the Protokolle entry stayed behind as a dead, empty flyout - in both navigations. The new navigation filters merge-anchor rail entries that end up with neither sections nor an own link after the plugin fragments merged. The legacy sidebar skips the whole Protokolle block unless at least one protocol plugin is active.
✅ Alle Checks bestanden2 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan – Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With eNOTF, fireTab and the MANV board all disabled, Protokolle stayed behind as a dead, empty flyout — in both navigations.
mergeNavigation()now filters merge-anchor rail entries that end up with neither sections nor an ownhrefafter the plugin fragments merged — generic, works for any future anchor entry.