Move the SCSS sheets into the Vite build - #327
Merged
Merged
Conversation
Badges, alerts and buttons in the core settings pages and the knowledge-base templates still used Bootstrap utility classes that only survive through the compat layer. They now use the existing design-system pieces: ignis-chip (with status variants), ignis-alert and ignis-btn. eNOTF keeps its own Bootstrap bundle on purpose. The modal attributes (data-bs-toggle/-dismiss) and data-bs-theme stay for now: four compat selectors still key off the theme attribute, so those fall to the dialog migration.
The stylesheets were the last piece of the old manual asset workflow: a sass CLI script with hardcoded path lists, producing committed .css/.min.css pairs next to their sources, while Tailwind and the vendor bundles already ran through Vite. Now a fourth build pass (vite build --mode styles) compiles all ten sheets to public/assets/dist/<name>.css - one build command, one output directory, and the CI asset check covers everything. Template references move from assets/css/*.min.css to the dist paths (two head components carried almost all of them). The generated css/min.css/map files leave the repo; the .scss sources stay put. Standalone CSS without a SCSS source (enotf-toast, enotf-modals, pages/calendar.css) is untouched. Side effect: Vite now resolves the wallpaper url() in style.scss and emits it relative to the css file, which fixes the background image for subdirectory installs (it was root-absolute before).
✅ Alle Checks bestanden57 Dateien geändert · Übersicht
Unit Tests ✅
Integration Tests ✅
Feature Tests (HTTP) ✅
Frontend Build ✅
PHPStan – Statische Analyse ✅
Security Audit ✅
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stylesheets were the last piece of the old manual asset workflow: a sass CLI script with hardcoded path lists producing committed
.css/.min.csspairs next to their sources, while Tailwind and the vendor bundles already ran through Vite. Now a fourth build pass (vite build --mode styles) compiles all ten sheets topublic/assets/dist/<name>.css.npm run build), one output directory, the CI asset check covers everything..scsssources stay. Standalone CSS without a SCSS source (enotf-toast, enotf-modals, pages/calendar.css) untouched.url()in style.scss and emits it relative to the css file — fixes the dashboard background for subdirectory installs (was root-absolute).npx vite build --mode styles --watch.cirs.css/dokumente.csshad zero references anywhere but keep being built — possibly dead sheets, worth a separate look.