fix(windows): bundle vulkan-1.dll to fix startup crash #1006
+113
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows users without the Vulkan runtime installed were experiencing "vulkan-1.dll not found" errors that prevented the app from starting. This affected Windows 10 systems, machines without dedicated GPUs, virtual machines, and clean Windows installations.
The root cause: our migration to transcribe-rs (PR #791) introduced a hard dependency on Vulkan through whisper-rs. Windows checks all DLLs in the import table at process startup, so the app fails immediately before any code runs.
The fix bundles vulkan-1.dll from the Vulkan SDK during CI builds. Since Tauri's
bundle.resourcesplaces files in aresources/subdirectory rather than next to the executable, I added NSIS installer hooks that move the DLL to the correct location after installation. Once the DLL is present, whisper.cpp's GGML backend gracefully falls back to CPU transcription on systems without GPU/Vulkan drivers.Note: This fix works for NSIS installers (the default). MSI installers don't support the same hook mechanism, but NSIS is the primary distribution method.
Fixes #829, fixes #840