Include skiplist file in the analysis info#4798
Open
barnabasdomozi wants to merge 1 commit intoEricsson:masterfrom
Open
Include skiplist file in the analysis info#4798barnabasdomozi wants to merge 1 commit intoEricsson:masterfrom
barnabasdomozi wants to merge 1 commit intoEricsson:masterfrom
Conversation
barnabasdomozi
force-pushed
the
extend_analysis_info
branch
from
a266ce7 to
95942c7
Compare
barnabasdomozi
added
database 🗄️
barnabasdomozi
force-pushed
the
extend_analysis_info
branch
3 times, most recently
from
8586d7c to
c1b9b9a
Compare
barnabasdomozi
force-pushed
the
extend_analysis_info
branch
4 times, most recently
from
a31604e to
3661f49
Compare
The skiplist file is already included in the store ZIP, but it is not currently stored in the database. This patch introduces a new table called AnalysisInfoFile, which is intended to store files related to analysis information. The actual file contents are stored separately in the FileContent table. With this PR, only the skipfile is included as an analysis info file, but this could be extended later.
barnabasdomozi
force-pushed
the
extend_analysis_info
branch
from
3661f49 to
39a5e15
Compare
dkrupp
requested changes
Mar 11, 2026
Member
dkrupp
left a comment
dkrupp
left a comment
There was a problem hiding this comment.
Please keep the original config file name.
Otherwise looks good.
| hashlib.md5(report_dir_path.encode('utf-8')).hexdigest()) | ||
|
|
||
| skip_file = os.path.join(zip_report_dir, 'skip_file') | ||
| if os.path.isfile(skip_file): |
Member
There was a problem hiding this comment.
It would be great to preserve the original file name of the config files as the user sees the command with its oriignal file name.
Now the name skip_file is wired in. ... And I see that it is wired in at the analysis client.
I suggest creating a "conf" subdirectory in the report_directory where you collect all config files used by the CodeChecker analyze command with their original names.
Then the name could be preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The skiplist file is already included in the store ZIP, but it is not currently stored in the database.
This patch introduces a new table called AnalysisInfoFile, which is intended to store files related to analysis information. The actual file contents are stored separately in the FileContent table.
With this PR, only the skipfile is included as an analysis info file, but this could be extended later.