Skip to content

Bazel 8 support#203

Open
nettle wants to merge 2 commits intoEricsson:mainfrom
nettle:bazel-8
Open

Bazel 8 support#203
nettle wants to merge 2 commits intoEricsson:mainfrom
nettle:bazel-8

Conversation

@nettle
Copy link
Collaborator

@nettle nettle commented Mar 8, 2026

Why:
Bazel 8 is actual version, we have to support it

What:
Add support Bazel 8

Addresses:
#108

@nettle
Copy link
Collaborator Author

nettle commented Mar 8, 2026

Hi @furtib, @Szelethus,
I've just briefly added support for Bazel 8, but tested only test/unit/legacy
I hope it should be about updating tests to add load("@rules_cc//cc:defs.bzl", "cc_binary", "cc_library")

@nettle nettle requested review from Szelethus and furtib and removed request for Szelethus March 8, 2026 21:46
Copy link
Contributor

@furtib furtib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a proof-of-concept patch to me. (The 5th in this series: #116, #140, #174, #199)

Hard-coding the shebang is certainly an option we have yet to explore.

For me (not using mise), all tests are passing, even the per_file = True in yaml-cpp.
(tested with: bazel 6.5, 7.5, 8.5)
For the external tests, we already have a patch (#159)

Do note, however:

  • The shebang will use the system version of Python, not the one provided by rules_python
    To verify this claim, try:
    (The script hides the Python interpreter present on the system, forcing bazel to use the one provided by rules_python)
mv $(which python3) $(which python3).dis; bazel build //test/unit/legacy:codechecker_pass; mv $(which python3.dis) $(echo $(which python3.dis) | sed 's/\.dis$//')

(If we actually did use the rules_python toolchain, the test would pass)

@nettle
Copy link
Collaborator Author

nettle commented Mar 11, 2026

The shebang will use the system version of Python, not the one provided by rules_python

Yes, this is actually truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants