Conversation
|
Hi @furtib, @Szelethus, |
There was a problem hiding this comment.
This seems like a proof-of-concept patch to me. (The 5th in this series: #116, #140, #174, #199)
Hard-coding the shebang is certainly an option we have yet to explore.
For me (not using mise), all tests are passing, even the per_file = True in yaml-cpp.
(tested with: bazel 6.5, 7.5, 8.5)
For the external tests, we already have a patch (#159)
Do note, however:
- The shebang will use the system version of Python, not the one provided by rules_python
To verify this claim, try:
(The script hides the Python interpreter present on the system, forcing bazel to use the one provided by rules_python)
mv $(which python3) $(which python3).dis; bazel build //test/unit/legacy:codechecker_pass; mv $(which python3.dis) $(echo $(which python3.dis) | sed 's/\.dis$//')
(If we actually did use the rules_python toolchain, the test would pass)
Yes, this is actually truth. |
Why:
Bazel 8 is actual version, we have to support it
What:
Add support Bazel 8
Addresses:
#108