fix: prevent crash when encoding payload with invalid UTF-8#323
Open
agity7 wants to merge 1 commit intoExafunction:mainfrom
Open
fix: prevent crash when encoding payload with invalid UTF-8#323agity7 wants to merge 1 commit intoExafunction:mainfrom
agity7 wants to merge 1 commit intoExafunction:mainfrom
Conversation
…nt crash on invalid UTF-8 when encoding request body
|
Philippe seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
aliaksandr-trush
approved these changes
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR wraps
vim.fn.json_encode()in apcall()to avoid crashing when Codeium tries to encode invalid UTF-8 payloads.Problem
Some buffers (e.g., minified
.mjs,.sum, or binary-like files) contain invalid UTF-8. Codeium tries to encode the completion request payload withvim.fn.json_encode, leading to:Vim:E474: String contains byte that does not start any UTF-8 character
Fix
pcall.Tested locally with such files, and Codeium no longer crashes.
Fixes a class of bugs seen when using preview panels or telescope buffers as well.