Added package updating to &update#437
Open
JayFromProgramming wants to merge 2 commits intoFRCDiscord:masterfrom
Open
Added package updating to &update#437JayFromProgramming wants to merge 2 commits intoFRCDiscord:masterfrom
JayFromProgramming wants to merge 2 commits intoFRCDiscord:masterfrom
Conversation
…lled Signed-off-by: JayFromProgramming <ajsweene@mtu.edu>
tweirtx
requested changes
May 4, 2023
Member
tweirtx
left a comment
tweirtx
left a comment
There was a problem hiding this comment.
I'd prefer if it detected requirements.txt in the git log and only fired off the update then
devyntk
requested changes
May 4, 2023
Member
devyntk
left a comment
devyntk
left a comment
There was a problem hiding this comment.
Agreed with travis - this may be indicative of larger packaging problems to solve, as just a bare pip requirements file isn't exactly stable nor convenient. I'm a fan of Poetry and I've used it for other projects, but open to other suggestions. I don't think a packaging change needs to be in this PR, but identifying a change in a Poetry lockfile may be easier than parsing requirements.txt.
Contributor
|
I agree with Travis that the requirements should only only run when needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dozer will now run pip install when running &update so dozer will no longer have the chance of not restarting after an update due to missing requirements