chore(rescueCfdi): add rescue cfdi in documentation - #288
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds documentation for the “rescue CFDI” flow (background recovery after recognized intermittent stamping errors) to the OpenAPI v2 specs, including the new 202 Accepted response scenario and updated webhook description context.
Changes:
- Documented the background recovery process and retry timeline for intermittent PADE stamping errors.
- Added a
202response definition for invoice creation when stamping is pending recovery. - Updated the invoice status webhook description to include recovery-task-triggered status updates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| website/openapi_v2.yaml | Spanish OpenAPI spec updates: recovery narrative, 202 response, webhook description tweak. |
| website/openapi_v2.en.yaml | English OpenAPI spec updates: recovery narrative, 202 response, webhook description tweak. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
javorosas
approved these changes
Aug 4, 2026
raul-facturapi
force-pushed
the
FAC-2108_rescue_cfdi
branch
from
August 7, 2026 05:00
9d41d7b to
ced544c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
Suppressed comments (2)
website/openapi_v2.yaml:3263
- En esta descripción se afirma que el folio queda reservado “durante seis horas”, pero más abajo se indica que si el 5º intento falla se libera el folio (~50 min). Para evitar la contradicción, conviene aclarar que la reserva es hasta seis horas o hasta que termine la recuperación (éxito/fracaso).
Si PADE devuelve un error intermitente reconocido durante el timbrado, Facturapi conserva la factura con `status: "pending"`, sin UUID y con su sello CFD original. El folio queda reservado durante seis horas y la API responde con `202 Accepted`. Esto significa que la solicitud fue aceptada, pero su procesamiento todavía no termina. Los errores de validación y demás errores que no sean elegibles para recuperación se devuelven de forma normal.
website/openapi_v2.en.yaml:3037
- This description says the folio “remains reserved for six hours”, but later it says the folio is released if the 5th attempt fails (~50 minutes). To avoid contradicting itself, clarify that the reservation is up to six hours or until the recovery finishes (success/failure).
If PADE returns a recognized intermittent error during stamping, Facturapi preserves the invoice with `status: "pending"`, no UUID, and its original CFD signature. The folio remains reserved for six hours, and the API responds with `202 Accepted`. This means that the request was accepted, but processing has not finished. Validation errors and other errors that are not eligible for recovery are returned normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.