Skip to content

ci(boards): add LPC845-BRK + LPCXpresso804 stub workflows and README badges#536

Merged
zackees merged 1 commit into
mainfrom
feat/lpc8xx-stub-workflows
Jun 12, 2026
Merged

ci(boards): add LPC845-BRK + LPCXpresso804 stub workflows and README badges#536
zackees merged 1 commit into
mainfrom
feat/lpc8xx-stub-workflows

Conversation

@zackees

@zackees zackees commented Jun 12, 2026

Copy link
Copy Markdown
Member

Summary

Why stubs, not real builds

Quoting the in-file rationale:

No-op stub. The NxpLpc orchestrator DOES build this variant — proof: fbuild build . -e lpc845brk is green on main in upstream zackees/ArduinoCore-LPC8xx CI (variant source of truth). This stub only exists because there's no in-tree fixture for it yet (no tests/platform/lpc845brk/; the board JSON boards/json/lpc845brk.json landed in PR #514).

History: a previous attempt used continue-on-error: true on the reusable-workflow caller, but that keyword is NOT in GitHub's allow-list for reusable callers — every push went red with a "workflow file issue" before any job actually ran. The no-op pass below sidesteps that limitation.

What was deliberately dropped from the original draft

The draft also contained a stub replacement for build-lpcxpresso845max.yml. That premise is stale: PR #514 (merged 2026-06-09) already shipped the real template_build.yml caller together with tests/platform/lpcxpresso845max/platformio.ini and boards/json/lpcxpresso845max.json, and the workflow has been green on main for its last 10 runs. Stubbing it out would regress a working build, so this PR leaves it untouched.

Test plan

  • actionlint clean on both new workflow files
  • Stub jobs only run echo steps — expected green
  • Full check matrix green (or failures pre-existing on main)

Refs #528, #487

🤖 Generated with Claude Code

…badges

Add passing no-op CI slots for the two ArduinoCore-LPC8xx variants that
do not yet have in-tree fixtures (tests/platform/<variant>/). Board
JSONs already landed in #514; conversion to real template_build.yml
callers is tracked in #528 (Stage 8 of META #487).

The originally drafted lpcxpresso845max stub is intentionally NOT
included: PR #514 already shipped the real template_build.yml caller
plus fixture and board JSON, and that workflow is green on main.

Refs #528, #487

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 45 minutes and 36 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 56259e17-543e-4319-b3c8-21fb170fca70

📥 Commits

Reviewing files that changed from the base of the PR and between 2be62bf and 3420234.

📒 Files selected for processing (3)
  • .github/workflows/build-lpc845brk.yml
  • .github/workflows/build-lpcxpresso804.yml
  • README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/lpc8xx-stub-workflows

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 29d27d0 into main Jun 12, 2026
90 checks passed
@zackees zackees deleted the feat/lpc8xx-stub-workflows branch June 12, 2026 19:32
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jun 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant