feat: change params to options object #601
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
synapse-dev | 004977b | Commit Preview URL Branch Preview URL |
Feb 10 2026, 07:24 PM |
hugomrdias
force-pushed
the
hugomrdias/obj-params
branch
from
e124516 to
30ae9b8
Compare
…permit deadlines, and standardize client address parameter
…ageInfo and change download method to object params
hugomrdias
force-pushed
the
hugomrdias/obj-params
branch
from
831d2a8 to
cdd7473
Compare
|
|
||
| const amount = parseUnits("100"); | ||
| const hash = await synapse.payments.depositWithPermit(amount); | ||
| const hash = await synapse.payments.depositWithPermit({amount}); |
There was a problem hiding this comment.
we don't have a lint rule on mdx files? this should be spaced to be consistent with the rest of the docs and with the linter rules for the code I think, 3 instances of {amount} here, docs/src/content/docs/developer-guides/payments/rails-settlement.mdx has the same problem, the others look fine I think
| // ---cut--- | ||
| // Check current USDFC balance | ||
| const walletBalance = await synapse.payments.walletBalance(TOKENS.USDFC); | ||
| const walletBalance = await synapse.payments.walletBalance({token:TOKENS.USDFC}); |
|
|
||
| // Download from this context | ||
| const downloaded = await context.download(result.pieceCid); | ||
| const downloaded = await context.download({pieceCid: result.pieceCid}); |
There was a problem hiding this comment.
I'm not convinced about address here, its the client whose data sets we are looking for, an address could be anything - SP address, contract address, ..
There was a problem hiding this comment.
it could be wallet to align with some of the payments terminology
| } | ||
|
|
||
| const deadline = options.deadline ?? BigInt(Math.floor(Date.now() / 1000) + 3600) // 1 hour | ||
| const deadline = options.deadline ?? BigInt(Math.floor(Date.now() / 1000) + TIME_CONSTANTS.PERMIT_DEADLINE_DURATION) |
| const filBalance = await synapse.payments.walletBalance() | ||
| const usdfcBalance = await synapse.payments.walletBalance('USDFC') | ||
| const usdfcBalance = await synapse.payments.walletBalance({ | ||
| token: 'USDFC', |
There was a problem hiding this comment.
maybe we should be using the constant for this one, easy to mistype as USDC
3 participants
Uh oh!
There was an error while loading. Please reload this page.