Open
Conversation
The current script has some drawbacks:
- It spawns a sed command for each .age file.
- If "$PREFIX" contains newline, sed command won't work correctly.
- Using "$PREFIX" as pattern may lead to code injection.
Fixing those things are simple:
- cd to "$PREFIX" before running find, we do this in subshell, so no
effect to the current shell.
- Use "find ... -exec sh -c '' sh-find {} +" form, so we can process as
much as possible for each exec sh.
- Use parameter expansion for stripping "./" prefix and ".age" suffix.
The script is now safer, maybe faster, and guarantee to work in all
POSIX shells.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current script has some drawbacks:
Fixing those things are simple:
The script is now safer, maybe faster, and guarantee to work in all POSIX shells.