feat: add optional opsx brief workflow#1215
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds an optional ChangesAdd /opsx:brief workflow
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
alfred-openspec
left a comment
There was a problem hiding this comment.
Thanks for putting this together. I like the shape: optional workflow, not core, generated through the same skill/command pipeline, and the source-attribution guardrails are the right boundary for a non-authoritative HTML review surface.
One change I’d make before merging: the new template names an AskUserQuestion tool for ambiguous change selection. That is not part of the stable cross-agent OpenSpec workflow contract, and these templates install across agents that will not have that tool. Please make this agent-agnostic, for example “ask the user to select from the available changes,” or mirror the wording from the apply/archive templates.
|
Addressed in 9141c8f: the brief workflow selection instructions no longer reference the |
alfred-openspec
left a comment
There was a problem hiding this comment.
Looks good now. The ambiguous-change selection wording is agent-agnostic, and the optional workflow wiring matches the existing profile/template generation pattern.\n\nVerified locally: targeted profile/generation/init/update/reference tests passed (7 files / 183 tests), build passed, and openspec validate add-brief-workflow --strict passed.
Require brief output to keep full source artifact coverage, label inferred impacts, avoid fallback claims from non-goals, and stay standalone with system fonts and project-neutral branding.
68562ea to
24fbdd4
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/commands.md`:
- Around line 321-360: The example fences in the /opsx:brief section are missing
a language identifier, causing the markdownlint warning. Update both fenced
blocks in the command example to include the same explicit language tag (use the
fence style already implied by the review comment) so the markdown remains
lint-clean; locate the change in the /opsx:brief documentation example rather
than the prose above or below it.
In `@docs/opsx.md`:
- Around line 206-213: The example fence in the “Review before implementation”
section is missing a language tag, causing the markdownlint warning. Update the
fenced block to use a language identifier such as text in the example around
/opsx:brief add-dark-mode, keeping the rest of the docs content unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a5a726fe-4393-4acf-ad81-a730ea6d46f8
📒 Files selected for processing (23)
docs/commands.mddocs/opsx.mddocs/supported-tools.mddocs/workflows.mdopenspec/changes/add-brief-workflow/design.mdopenspec/changes/add-brief-workflow/proposal.mdopenspec/changes/add-brief-workflow/specs/opsx-brief-skill/spec.mdopenspec/changes/add-brief-workflow/tasks.mdsrc/commands/config.tssrc/core/init.tssrc/core/profile-sync-drift.tssrc/core/profiles.tssrc/core/shared/skill-generation.tssrc/core/shared/tool-detection.tssrc/core/templates/skill-templates.tssrc/core/templates/workflows/brief-change.tstest/core/init.test.tstest/core/profiles.test.tstest/core/shared/skill-generation.test.tstest/core/shared/tool-detection.test.tstest/core/templates/skill-templates-parity.test.tstest/core/update.test.tstest/utils/command-references.test.ts
💤 Files with no reviewable changes (14)
- test/utils/command-references.test.ts
- test/core/shared/tool-detection.test.ts
- src/core/templates/skill-templates.ts
- src/core/profiles.ts
- src/core/profile-sync-drift.ts
- src/core/init.ts
- test/core/update.test.ts
- test/core/shared/skill-generation.test.ts
- src/core/templates/workflows/brief-change.ts
- src/core/shared/tool-detection.ts
- test/core/templates/skill-templates-parity.test.ts
- test/core/init.test.ts
- src/core/shared/skill-generation.ts
- test/core/profiles.test.ts
✅ Files skipped from review due to trivial changes (5)
- openspec/changes/add-brief-workflow/tasks.md
- docs/workflows.md
- src/commands/config.ts
- docs/supported-tools.md
- openspec/changes/add-brief-workflow/proposal.md
🚧 Files skipped from review as they are similar to previous changes (2)
- openspec/changes/add-brief-workflow/specs/opsx-brief-skill/spec.md
- openspec/changes/add-brief-workflow/design.md
Address markdownlint MD040 on the newly added /opsx:brief examples flagged by CodeRabbit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Rebased onto the latest
|
Summary
/opsx:briefworkflow as generated skill/command templatesbriefin custom workflow selection without adding it to the core profileVerification
node build.js./node_modules/.bin/eslint src/./node_modules/.bin/vitest runnode bin/openspec.js validate add-brief-workflow --strictnode bin/openspec.js status --change add-brief-workflow --jsonSummary by CodeRabbit
Release Notes
New Features
/opsx:briefto generate a one-page, standalonebrief.htmlreview brief from existing change artifacts, including source attribution and explicit handling of missing/uncertain info (no guessing).Documentation
/opsx:brief.Tests