feat: remove org-id annotation requirement#20
Closed
talissoncosta wants to merge 5 commits intomainfrom
Closed
Conversation
The Flagsmith API returns tags as an array of numeric IDs, but the UI was displaying these IDs directly. This fix fetches tag definitions from the project and creates a lookup map to display labels instead. - Add FlagsmithTag interface and getProjectTags method to FlagsmithClient - Update useFlagsmithProject hook to fetch tags and provide tagMap - Update components to use tagMap for resolving tag labels - Update mock handlers with realistic tag data Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Create a shared TagChip component that displays colored tags using the Flagsmith dashboard style: light tinted background, subtle border, and darkened text color derived from each tag's color field. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Instead of displaying numeric tag IDs as a fallback, the TagChip component now returns null when the tag is not found in the tagMap. This prevents confusing numeric IDs from appearing in the UI. Also removed unnecessary parseInt conversion for projectId in the getProjectTags API call since the parameter already accepts strings. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Exports TagChip from the shared components index file for consistency with other shared components. Updates imports in ExpandableRow and FeatureDetailsGrid to use the cleaner import pattern. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Remove org-id annotation requirement - automatically derive from project data - Simplify useFlagsmithUsage hook to only require project-id - Update FlagsmithUsageCard to derive org-id from project - Add /flagsmith-complete demo page showing all three components - Update tests to reflect simplified API - Update documentation to remove org-id references This improves developer experience by reducing required configuration. The organization ID is always available in the project response, so requiring users to manually provide it was unnecessary. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
Closing in favor of clean rebased branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR simplifies the plugin configuration by removing the
flagsmith.com/org-idannotation requirement. The organization ID is now automatically derived from the project data, reducing the configuration burden on users.Changes
Core Changes
org-idannotation requirement: TheuseFlagsmithUsagehook now only requiresproject-idprojectData.organisationorgIdparameter fromuseFlagsmithUsagehookComponent Updates
FlagsmithUsageCardto derive org-id from project dataDeveloper Experience
/flagsmith-completedemo page: Shows all three components (FlagsTab, Overview Card, Usage Card) on one screenDocumentation
Tests
useFlagsmithUsage.test.tsxto reflect simplified APIBefore vs After
Before:
After:
Benefits
Testing
All three components work with only
project-idannotation:Try it out:
yarn startand visit/flagsmith-completeBreaking Changes
useFlagsmithUsage, but:org-idannotation was already documented as "optional"org-idannotation will continue to work (it's just ignored)