Merged
Conversation
emyller
approved these changes
May 8, 2026
khvn26
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #214 , restoring previous behavior
Fixes
MismatchedInputExceptionthrown by SDK 8.0.0–8.1.0 when deserializing/api/v1/identities/responses from self-hosted Core/EE that include a flag with a segment override.Root cause: PR feat!: Context Values support,
getEvaluationResult#184 dropped theFeatureSegmentModel(Integer)constructor that Jackson was using as a delegating creator to coerce Core/EE's integer FK shape (feature_segment: 321) into the model. Edge emitsfeature_segment: {"priority": <int>}and is unaffected.Restores the
Integer-arg constructor (mirrors pre-feat!: Context Values support,getEvaluationResult#184 shape) so both wire formats deserialize correctly.SaaS /
edge.api.flagsmith.comusers were never affected.Core/EE wire-format inconsistency is the deeper issue and will be tracked separately — the SDK still needs this tolerance long-term to support older self-hosted installs.
Test plan
Added
FeatureSegmentModelTestcovering the three shapes: integer FK (Core/EE), engine object (Edge), and null (no segment override). Verified the integer-FK test fails onmainwith the reported exception, then passes after the fix.