fix: add loading state for MultiSelect in Create Segment modal#6565
Merged
talissoncosta merged 1 commit intomainfrom Jan 23, 2026
Merged
fix: add loading state for MultiSelect in Create Segment modal#6565talissoncosta merged 1 commit intomainfrom
talissoncosta merged 1 commit intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Docker builds report
|
kyle-ssg
approved these changes
Jan 21, 2026
Fixes #6544 Co-Authored-By: Claude Opus 4.5 <[email protected]>
8459855 to
4ced8a9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature.Changes
Closes #6544
Adds a loading state check for the
MultiSelectcomponent inRuleConditionValueInputto prevent crashes when opening the Create Segment modal with environment-based operators.Root Cause: When
showMultiEnvironmentSelectistruebutprojectIdis undefined or environments haven't loaded yet, react-select crashes internally with:TypeError: Cannot read properties of null (reading 'reduce')null is not an object (evaluating 'e.options.reduce')Fix:
isLoadingcheck for whenprojectIdis undefined ordata?.resultshasn't loadedSentry Issues:
How to reproduce
/project/{id}/segments)environmentIN,NOT_IN)Alternative reproduction (simulating the race condition):
How did you test this code?