-
Notifications
You must be signed in to change notification settings - Fork 3
chore: temporarily disable nx cloud #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
WalkthroughThis pull request comments out Nx Cloud-related steps and replaces Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/actions/setup/action.yml (1)
12-14: Consider marking CODECOV_TOKEN as optional for future cleanup.The
CODECOV_TOKENinput is no longer used within this action since the Nx Cloud step (which consumed it) is now commented out. While the parent workflow still needs this token for the codecov action, this setup action doesn't use it anymore.For a temporary change, keeping it as-is is fine. For a longer-term solution, consider either removing this input or marking it as
required: false..github/workflows/ci.yml (1)
6-7: Consider removing unused Nx Cloud environment variables for cleanup.The
NX_CLOUD_ENCRYPTION_KEYandNX_CLOUD_ACCESS_TOKENenvironment variables are no longer used since the Nx Cloud steps are commented out.For a temporary change, keeping them is fine and makes it easier to re-enable. For a longer-term solution, consider removing these to reduce clutter and avoid confusion.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/actions/setup/action.yml.github/workflows/ci.yml
🔇 Additional comments (3)
.github/actions/setup/action.yml (1)
41-46: LGTM! Clean temporary disabling of Nx Cloud.The approach of commenting out the Nx Cloud start step with an explanatory comment makes it easy to re-enable when the security concerns are resolved. The rest of the workflow continues to function correctly.
.github/workflows/ci.yml (2)
35-37: LGTM! Consistent disabling of Nx Cloud fix-ci step.The approach of commenting out the Nx Cloud fix-ci step aligns well with the related change in
.github/actions/setup/action.yml. The explanatory comment makes the temporary nature clear.
45-45: Verify workflow functions correctly without Nx Cloud.The
--no-agentsflag appropriately disables distributed execution now that Nx Cloud is disabled. However, it's worth confirming that:
- The Nx commands throughout the workflow still execute successfully without Nx Cloud
- CI run times are acceptable (though slower, as noted in the PR description)
- No Nx Cloud-specific features are inadvertently relied upon elsewhere in the workflow
Run the workflow on this PR to confirm it completes successfully without Nx Cloud enabled.
cf5a2d9 to
0f59e6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci-fork.yml (1)
59-60: The change appropriately disables distributed e2e testing during Nx Cloud unavailability.Both the
e2eande2e-citargets exist and are properly configured in nx.json. Thee2etarget is designed for local execution, whilee2e-cirequires Nx Cloud for distributed task execution. By switching toe2ewith--no-agents, the workflow correctly prevents failed attempts at distributed execution while maintaining e2e test coverage.Consider adding a tracking issue to re-enable Nx Cloud and revert to
e2e-cionce the security concerns are resolved.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/actions/setup/action.yml.github/workflows/ci-fork.yml.github/workflows/ci.yml
🚧 Files skipped from review as they are similar to previous changes (2)
- .github/workflows/ci.yml
- .github/actions/setup/action.yml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-28T14:44:26.883Z
Learnt from: ryanbas21
Repo: ForgeRock/ping-javascript-sdk PR: 427
File: .github/workflows/ci-fork.yml:50-56
Timestamp: 2025-10-28T14:44:26.883Z
Learning: Nx CLI accepts multiple targets with the short `-t` flag as space-separated tokens (e.g., `nx affected -t lint test build`) and also supports comma-separated values with the long form `--targets=` (e.g., `nx affected --targets=lint,test,build`). Both syntaxes are valid.
Applied to files:
.github/workflows/ci-fork.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: pr
|
ping-javascript-sdk/.github/workflows/ci.yml Lines 6 to 7 in 0f59e6a
I think we may need to comment out the keys. If we still have those, it's still able to read from the cache. The lines we commented out I think will just disable Nx's DTE May need to do the same on publish.yml as well |
Description
Temporarily disable Nx Cloud until security concerns with Nx Cloud Github app are resolved. This disables remote caching for CI so it will be slower for now. Self-healing will also be disabled.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.