Skip to content

Conversation

@ancheetah
Copy link
Collaborator

@ancheetah ancheetah commented Dec 22, 2025

Description

Temporarily disable Nx Cloud until security concerns with Nx Cloud Github app are resolved. This disables remote caching for CI so it will be slower for now. Self-healing will also be disabled.

Summary by CodeRabbit

  • Chores
    • CI/CD pipeline updated: cloud optimization step temporarily disabled and end-to-end check simplified (e2e-ci replaced with e2e).
    • Other workflow steps (build, test, coverage, docs) remain unchanged; overall behavior preserved.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot
Copy link

changeset-bot bot commented Dec 22, 2025

⚠️ No Changeset found

Latest commit: 0f59e6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Walkthrough

This pull request comments out Nx Cloud-related steps and replaces e2e-ci with e2e in GitHub Actions configuration. The Nx Cloud initialization/finalization steps are disabled (commented), and CI fork workflow uses the e2e target with an explanatory comment; other CI steps remain unchanged.

Changes

Cohort / File(s) Change Summary
Setup action
/.github/actions/setup/action.yml
Nx Cloud start step (pnpm dlx nx-cloud start-ci-run) replaced with a commented block; CODECOV_TOKEN context remains present but inactive.
Primary CI workflow
/.github/workflows/ci.yml
Nx Cloud fix step (npx nx-cloud fix-ci) commented out, disabling finalization while leaving remaining workflow steps intact.
Fork CI workflow
/.github/workflows/ci-fork.yml
Replaced e2e-ci target with e2e and added a comment noting e2e-ci is temporarily disabled until Nx Cloud is available; other arguments unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Changes are small and repetitive across CI files but require checking workflow behavior.
  • Areas to focus on:
    • Confirm the commented Nx Cloud steps are fully inert (no stray execution).
    • Validate that switching e2e-cie2e preserves expected test target behavior.
    • Ensure CODECOV_TOKEN usage remains correct and unaffected.

Poem

I’m a rabbit in the CI glen, softly I tread,
I tuck away cloud-steps and pat them to bed.
With a nibble of comment, the pipelines keep song,
Hopping through tests, the rest runs along. 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: temporarily disabling Nx Cloud across CI workflows and action configurations.
Description check ✅ Passed The description adequately explains the purpose of disabling Nx Cloud and its impact, though it lacks a JIRA ticket reference as shown in the template.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch disable-nx-cloud

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
.github/actions/setup/action.yml (1)

12-14: Consider marking CODECOV_TOKEN as optional for future cleanup.

The CODECOV_TOKEN input is no longer used within this action since the Nx Cloud step (which consumed it) is now commented out. While the parent workflow still needs this token for the codecov action, this setup action doesn't use it anymore.

For a temporary change, keeping it as-is is fine. For a longer-term solution, consider either removing this input or marking it as required: false.

.github/workflows/ci.yml (1)

6-7: Consider removing unused Nx Cloud environment variables for cleanup.

The NX_CLOUD_ENCRYPTION_KEY and NX_CLOUD_ACCESS_TOKEN environment variables are no longer used since the Nx Cloud steps are commented out.

For a temporary change, keeping them is fine and makes it easier to re-enable. For a longer-term solution, consider removing these to reduce clutter and avoid confusion.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between af4bf4c and cf5a2d9.

📒 Files selected for processing (2)
  • .github/actions/setup/action.yml
  • .github/workflows/ci.yml
🔇 Additional comments (3)
.github/actions/setup/action.yml (1)

41-46: LGTM! Clean temporary disabling of Nx Cloud.

The approach of commenting out the Nx Cloud start step with an explanatory comment makes it easy to re-enable when the security concerns are resolved. The rest of the workflow continues to function correctly.

.github/workflows/ci.yml (2)

35-37: LGTM! Consistent disabling of Nx Cloud fix-ci step.

The approach of commenting out the Nx Cloud fix-ci step aligns well with the related change in .github/actions/setup/action.yml. The explanatory comment makes the temporary nature clear.


45-45: Verify workflow functions correctly without Nx Cloud.

The --no-agents flag appropriately disables distributed execution now that Nx Cloud is disabled. However, it's worth confirming that:

  1. The Nx commands throughout the workflow still execute successfully without Nx Cloud
  2. CI run times are acceptable (though slower, as noted in the PR description)
  3. No Nx Cloud-specific features are inadvertently relied upon elsewhere in the workflow

Run the workflow on this PR to confirm it completes successfully without Nx Cloud enabled.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/ci-fork.yml (1)

59-60: The change appropriately disables distributed e2e testing during Nx Cloud unavailability.

Both the e2e and e2e-ci targets exist and are properly configured in nx.json. The e2e target is designed for local execution, while e2e-ci requires Nx Cloud for distributed task execution. By switching to e2e with --no-agents, the workflow correctly prevents failed attempts at distributed execution while maintaining e2e test coverage.

Consider adding a tracking issue to re-enable Nx Cloud and revert to e2e-ci once the security concerns are resolved.

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf5a2d9 and 0f59e6a.

📒 Files selected for processing (3)
  • .github/actions/setup/action.yml
  • .github/workflows/ci-fork.yml
  • .github/workflows/ci.yml
🚧 Files skipped from review as they are similar to previous changes (2)
  • .github/workflows/ci.yml
  • .github/actions/setup/action.yml
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-10-28T14:44:26.883Z
Learnt from: ryanbas21
Repo: ForgeRock/ping-javascript-sdk PR: 427
File: .github/workflows/ci-fork.yml:50-56
Timestamp: 2025-10-28T14:44:26.883Z
Learning: Nx CLI accepts multiple targets with the short `-t` flag as space-separated tokens (e.g., `nx affected -t lint test build`) and also supports comma-separated values with the long form `--targets=` (e.g., `nx affected --targets=lint,test,build`). Both syntaxes are valid.

Applied to files:

  • .github/workflows/ci-fork.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: pr

@ryanbas21
Copy link
Collaborator

ryanbas21 commented Dec 22, 2025

NX_CLOUD_ENCRYPTION_KEY: ${{ secrets.NX_CLOUD_ENCRYPTION_KEY }}
NX_CLOUD_ACCESS_TOKEN: ${{ secrets.PR_NX_CLOUD_ACCESS_TOKEN }} # Read Only

I think we may need to comment out the keys. If we still have those, it's still able to read from the cache. The lines we commented out I think will just disable Nx's DTE

May need to do the same on publish.yml as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants