Conversation
Collaborator
Author
|
Actually I seen that Lisa has been working on that cleanup so I'll wait for that MR to come up |
|
Just making sure I understand the order of operations - do we need to cut the next rx version before we can merge this MR? |
Collaborator
Author
|
To be safe yeah. Nobody should be running those setup scripts that install these packages, but we should remove them before this is merged |
RyanBrushett
approved these changes
Jan 28, 2026
Member
There was a problem hiding this comment.
Afterwards, we'll wanna remove the bottles from the "release" as well
EDIT: See https://github.com/Fullscript/homebrew-tools/releases/tag/bottles
Collaborator
|
I think this is ready to be merged now? |
Collaborator
Author
|
Yeah I think we need to kick off a release in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer need these custom formula for cloud dev so we can go ahead and remove them.
Before this is merged I'm going to do a quick cleanup in rx to remove/edit all the setup scripts that install these