replace implicit 'to' cast with @:to function for Haxe 4.3 compatibility#24
Closed
HomuHomu833 wants to merge 1 commit into
Closed
replace implicit 'to' cast with @:to function for Haxe 4.3 compatibility#24HomuHomu833 wants to merge 1 commit into
HomuHomu833 wants to merge 1 commit into
Conversation
…lity
haxe 4.3 introduced stricter validation for abstract `from/to` declarations, requiring us to do this change, the implicit `to flixel.util.FlxPool.IFlxPooled`
on FlxUVRect fails this check since FlxRect's underlying type isn't directly IFlxPooled.
```bash
ERROR C:/Users/Homura/GitHub/FNF-Shadow-Engine/.haxelib/flixel/git/flixel/graphics/frames/FlxFrame.hx:764: characters 45-75
764 | abstract FlxUVRect(FlxRect) from FlxRect to flixel.util.FlxPool.IFlxPooled
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| You can only declare from/to with compatible types
```
Author
|
I'm very wrong about this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
haxe 4.3 introduced stricter validation for abstract
from/todeclarations, requiring us to do this change, the implicitto flixel.util.FlxPool.IFlxPooledon FlxUVRect fails this check since FlxRect's underlying type isn't directly IFlxPooled.