Draft
Conversation
Bubusch
added
flag: requires updated TPL(s)
Bubusch
added
ci: run CUDA builds
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3561 +/- ##
========================================
Coverage 56.31% 56.31%
========================================
Files 1174 1174
Lines 102601 102601
========================================
Hits 57777 57777
Misses 44824 44824 ☔ View full report in Codecov by Sentry. |
MelReyCG
reviewed
Mar 21, 2025
Contributor
MelReyCG
left a comment
MelReyCG
left a comment
There was a problem hiding this comment.
@Bubusch Why is there no logs of unit-tests for the P4 GH job?
If you didn't run them because of the failing one, we can:
ctest -E "testPyCRSMatrix|testTensorOpsInverseOneArg|testTensorOpsInverseTwoArgs|testUncrustifyCheck|testDoxygenCheck"
(I excluded the testUncrustifyCheck as it is already done in the CI)
Collaborator
|
@Bubusch what is the status of this PR? |
Contributor
|
@rrsettgast - as code owner can you review this small one (linked with GEOS-DEV/thirdPartyLibs#296)? |
rrsettgast
approved these changes
Aug 13, 2025
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add build based on pangea-4 config :
Linked to TPL-296