Skip to content

Conversation

@dkachuma
Copy link
Contributor

@dkachuma dkachuma commented Feb 9, 2026

Proposing to bypass residual calculation for closed wells. The problem is that when the well is shut, some of the properties for the residual calculation are undefined.

@dkachuma dkachuma self-assigned this Feb 9, 2026
@dkachuma dkachuma added type: bug Something isn't working ci: run CUDA builds Allows to triggers (costly) CUDA jobs flag: ready for review ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.89%. Comparing base (5abf149) to head (074f42a).

Files with missing lines Patch % Lines
...rs/fluidFlow/wells/CompositionalMultiphaseWell.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3970      +/-   ##
===========================================
- Coverage    58.89%   58.89%   -0.01%     
===========================================
  Files         1353     1353              
  Lines       113035   113035              
===========================================
- Hits         66573    66571       -2     
- Misses       46462    46464       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants