refactor: Refactor arrayModifiers functions#225
Open
RomainBaville wants to merge 5 commits intomainfrom
Open
Conversation
RomainBaville
added
type: cleanup
test-geos-integration
RomainBaville
requested review from
jafranc and
paloma-martinez
and removed request for
paloma-martinez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr aims to refactor arrayModifiers functions to have just one function dealing with dataset or multiblock dataset instead of multiple functions.
During the factorisation of the arrayModifiers functions, a small clean is made in the tests to.