Skip to content

Conversation

@camierjs
Copy link
Contributor

@camierjs camierjs commented May 28, 2025

This PR adds DOFs numbering.

The n key now cycles in 2D: NONEELEMENTSEDGESVERTICESDOFS.

Should solve #106

GLVis_s01

Parallel numbering is now by default 'local' to each rank and can be toggled back to 'global' with Alt-n:
output
(mpirun -n 3 ./ex6p -m ../data/star-mixed.mesh -o 2 -md 200)

@tzanio
Copy link
Member

tzanio commented May 28, 2025

To clarify: "DOF" here means the numbering of the Mesh nodes (as a high-order grid function), right?

@najlkin najlkin linked an issue May 29, 2025 that may be closed by this pull request
@najlkin najlkin self-requested a review May 29, 2025 01:08
@najlkin
Copy link
Contributor

najlkin commented May 29, 2025

Js seems to be working: https://github.com/GLVis/glvis-js/actions/runs/15313952476 😉 Thanks for the cleanup 👍 I need to take a deeper look...

@najlkin
Copy link
Contributor

najlkin commented May 29, 2025

I tested that and it works nicely with 2D scalars on conforming meshes, but a few things to do:

  • update README
  • update Changelog
  • the current option could be written to console
  • 2D vector grid functions do something strange after pressing N, should be fixed
  • example 6 crashes glvis after switching to the second option, should be fixed

@najlkin
Copy link
Contributor

najlkin commented May 30, 2025

@tzanio , it shows DOFs (in the sense of finite element nodes) for the visualized grid function. In the case of mesh visualization, the nodes of the coloring grid function.

@tzanio tzanio mentioned this pull request Jan 5, 2026
34 tasks
@tzanio tzanio self-requested a review January 6, 2026 19:22
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thank you @camierjs !

@tzanio tzanio requested a review from rw-anderson January 14, 2026 23:31
Copy link
Contributor

@najlkin najlkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@najlkin najlkin added this to the glvis-4.5 milestone Jan 24, 2026
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @camierjs for adding this useful feature and @najlkin for the careful review! I am sure our users will appreciate it 🙏

@tzanio tzanio merged commit 96fa19a into master Jan 24, 2026
10 checks passed
@tzanio tzanio deleted the dofs_numbering branch January 24, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants